Improve item collection definition for clojure #2758
Merged
+52
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillco
reviewed
Jan 25, 2025
| { | ||
| :foo "bar", | ||
| ;; hello | ||
| , |
There was a problem hiding this comment.
This trailing comma with the four spaces of indentation looks a bit weird, could we make this look better? The other tests are clearly improvements
There was a problem hiding this comment.
This one is unfortunately quite hard. If the comment wasn't there the comma would be cleaned up. The whole thing about dealing with comments is something I intend to do in the future, but for now I think we will have to make due with this implementation.
There was a problem hiding this comment.
👍 Let's make sure we file it at some point
phillco
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some of the clojure collection item regression from #2683
Related #2723
Checklist